Read from IServerAddressesFeature for HTTPS port

aspnet / BasicMiddleware

[Archived] Basic middleware components for ASP.NET Core. Project moved to https://github.com/aspnet/AspNetCore

Apache License 2.0

169 stars 84 forks source link

Closed jkotalik closed 6 years ago

jkotalik commented 6 years ago

For #275 Few notes:

The middleware requires that the IServerAddressesFeature is implemented now (shouldn't be a problem, just something to note for tests)
I needed to create a new HttpsMiddleware (rather than use Urlrewrite) as we need to inject the IServerAddressFeature and evaluate it on first request.

jkotalik commented 6 years ago

I believe I addressed most of the feedback.

jkotalik commented 6 years ago

jkotalik commented 6 years ago

This now consumes BindingAddress. 🆙 📅

Tratcher commented 6 years ago

File followup bugs in Kestrel and HttpSys to consume the new BindingAddress