aspnet / BasicMiddleware

[Archived] Basic middleware components for ASP.NET Core. Project moved to https://github.com/aspnet/AspNetCore
Apache License 2.0
169 stars 84 forks source link

Test Failure: Microsoft.AspNetCore.ResponseCompression.Tests.ResponseCompressionMiddlewareTest.FlushBody_CompressesAndFlushes [FAIL] #298

Closed jkotalik closed 6 years ago

jkotalik commented 6 years ago

Saw this happen on AppVeyor: https://ci.appveyor.com/project/aspnetci/basicmiddleware/build/1.0.810. May be a flaky test. @Tratcher thoughts? @ryanbrandenburg if you see this happen on the CI, feel free to disable it.

Eilon commented 6 years ago

@muratg - critical now or 2.2.0-mq?

ryanbrandenburg commented 6 years ago

It looks like this failed 100% of the time on TC for a while, but hasn't failed since.

muratg commented 6 years ago

@ryanbrandenburg Ran but hasn't failed, or didn't run (disabled) hence hasn't failed?

If the former, is this one good to close?

ryanbrandenburg commented 6 years ago

Yeah, it's been running since, I'll close this out.