aspnet / BasicMiddleware

[Archived] Basic middleware components for ASP.NET Core. Project moved to https://github.com/aspnet/AspNetCore
Apache License 2.0
169 stars 84 forks source link

Set 2.1 baselines #338

Closed ryanbrandenburg closed 6 years ago

ryanbrandenburg commented 6 years ago

An API has been removed between 2.1 and dev. @Tratcher was this breaking changes intended/approved?

The following types have one or more members removed from them.

public class Microsoft.AspNetCore.HttpsPolicy.HstsMiddleware
    public .ctor(Microsoft.AspNetCore.Http.RequestDelegate next, Microsoft.Extensions.Options.IOptions<Microsoft.AspNetCore.HttpsPolicy.HstsOptions> options)

Following is the list of exclusions that either need to be added to the list of breaking changes, or the breaking changes themselves need to be reverted:
   [
     {
       "TypeId": "public class Microsoft.AspNetCore.HttpsPolicy.HstsMiddleware",
       "MemberId": "public .ctor(Microsoft.AspNetCore.Http.RequestDelegate next, Microsoft.Extensions.Options.IOptions<Microsoft.AspNetCore.HttpsPolicy.HstsOptions> options)",
       "Kind": "Removal"
     }
   ]
jkotalik commented 6 years ago

This was not intentional. We need to re-add the api.

Tratcher commented 6 years ago

Ah, https://github.com/aspnet/BasicMiddleware/commit/77c9bc38f914b78f53fd5828c68c4ceca44bd841#diff-a9c581affe19c089a2458ae1f14557b5. A parameter was added to the constructor. We need to add back the old constructor.

Tratcher commented 6 years ago

Filed https://github.com/aspnet/BasicMiddleware/issues/339