search

aspnet / BasicMiddleware

[Archived] Basic middleware components for ASP.NET Core. Project moved to https://github.com/aspnet/AspNetCore
Apache License 2.0
169 stars 84 forks source link

Handle IPv4ToIPv6 Mapped Addresses when checking known proxies/networks #359

Closed SebastianC closed 6 years ago

SebastianC commented 6 years ago

Un-Map IPv4-to-IPv6-Mapped ips before comparing to known proxies/networks.

Addresses #358

Tratcher commented 6 years ago

As discussed on the issue, this needs to check both versions of the IP.

Tratcher commented 6 years ago

The code looks good. Can you add some tests?

SebastianC commented 6 years ago

I would love to, but running into the following issue when I go to run unit tests:

Testhost process exited with error: It was not possible to find any compatible framework version
The specified framework 'Microsoft.NETCore.App', version '2.2.0-preview1-26618-02' was not found.

Downloading the current preview version from https://www.microsoft.com/net/download/dotnet-core/2.2 gives me a different version:

> dotnet --version
2.2.100-preview1-009349

Do you know how I can go about resolving this? @Tratcher

Tratcher commented 6 years ago

See https://github.com/aspnet/Home/wiki/Building-from-source

dnfclas commented 6 years ago

CLA assistant check
All CLA requirements met.