HostFilteringMiddleware uses C# interopolated strings for tracing

aspnet / BasicMiddleware

[Archived] Basic middleware components for ASP.NET Core. Project moved to https://github.com/aspnet/AspNetCore

Apache License 2.0

169 stars 84 forks source link

HostFilteringMiddleware uses C# interopolated strings for tracing #362

Closed daniel-white closed 6 years ago

daniel-white commented 6 years ago

HostFilteringMiddleware is using C# interopolated strings instead of passing the arguments off to the ILogger. I'm using Serilog which will cache the trace message, so if that changes, it will balloon. Plus, its causing more work for the middleware when the tracing is not turned up.

Tratcher commented 6 years ago

Agreed. Interested in sending a PR?

daniel-white commented 6 years ago

@Tratcher sure. which branch should i base it on?

Tratcher commented 6 years ago

release/2.2