aspnet / BasicMiddleware

[Archived] Basic middleware components for ASP.NET Core. Project moved to https://github.com/aspnet/AspNetCore
Apache License 2.0
169 stars 84 forks source link

Do not compress response if it is already compressed (#305) #365

Closed melnikov77 closed 6 years ago

melnikov77 commented 6 years ago

305

dnfclas commented 6 years ago

CLA assistant check
All CLA requirements met.

Tratcher commented 6 years ago

Thanks.

jkotalik commented 6 years ago

Few things I would like to confirm:

Tratcher commented 6 years ago

Do people ever want to double compress?

No, double compression is usually ineffective.

Is this a breaking change?

Only if someone was combining compression with some other type of content-encoding. While possible in theory, I haven't seen any such uses.