search

aspnet / BasicMiddleware

[Archived] Basic middleware components for ASP.NET Core. Project moved to https://github.com/aspnet/AspNetCore
Apache License 2.0
169 stars 84 forks source link

Refactor ModRewriteRedirect/Rewrite Action and Redirect/Rewrite Action together. #76

Closed jkotalik closed 8 years ago

jkotalik commented 8 years ago

Actions occur once the rule has passed. These can be consolidated into one class. Thought they needed to be distinct because of mod_rewrite allowing for more options, but we can probably construct UrlRewrite rules with defaults in mod_rewrite. See: https://github.com/aspnet/BasicMiddleware/blob/dev/src/Microsoft.AspNetCore.Rewrite/Internal/ModRewrite/ModRewriteRedirectAction.cs Versus https://github.com/aspnet/BasicMiddleware/blob/dev/src/Microsoft.AspNetCore.Rewrite/Internal/UrlActions/RedirectAction.cs

jkotalik commented 8 years ago

See #79

natemcmaster commented 8 years ago

Resolved by https://github.com/aspnet/BasicMiddleware/pull/77