aspnet / Benchmarks

Benchmarks for ASP.NET Core
Other
1.18k stars 242 forks source link

Add option to enable multuple H/3 connections #1998

Closed ManickaP closed 1 month ago

ManickaP commented 4 months ago

https://github.com/dotnet/runtime/pull/101531 follow up

cc @CarnaViire

CarnaViire commented 4 months ago

Changes LGTM -- have you tried to use the updated config YML to verify it works?

You can do it this way:

1) in <local-path-to-repo>/scenarios/httpclient.benchmarks.yml, change the pointers to the sources for the client job (jobs.httpClient.source.repository and jobs.httpClient.source.branchOrCommit) to point at your branch:

      repository: https://github.com/ManickaP/aspnet-benchmarks.git
      branchOrCommit: h3-mul-conns

2) use this local config file (instead of the remote one) in crank, and verify that both true and false values for the new parameter are passed and used correctly, e.g.:

-crank --config https://raw.githubusercontent.com/..../httpclient.benchmarks.yml --scenario ....
+crank --config <local-path-to-repo>/scenarios/httpclient.benchmarks.yml         --scenario .... --variable http30EnableMultipleConnections=false

HOW-TO: verify parameter is passed correctly

1) go to the job metadata on the agent (e.g. http://asp-citrine-lin:5001/jobs/100) and check the command line used to start the app, e.g.:

{
"driverVersion": ....,
....
"arguments": "--address .... --http30EnableMultipleConnections false ....",
....
}

-AND/OR-

2) go to the job logs on the agent (e.g. http://asp-citrine-lin:5001/jobs/100/output) and check the options printed, e.g.

[10:10:50.344] HttpClient benchmark
[10:10:50.353] Options: Address=....; .... Http30EnableMultipleConnections=False; ....
....
ManickaP commented 2 months ago

Resurrecting this PR, I rebased this on main and tested it:

So unless you have any more comments, can we get this in @CarnaViire ?