search

aspnet / Benchmarks

Benchmarks for ASP.NET Core
Other
1.18k stars 242 forks source link

HttpClient benchmarks broken #2006

Closed sebastienros closed 2 months ago

sebastienros commented 3 months ago

@CarnaViire can you try to find the reason?

sebastienros commented 3 months ago

Related to that, I removed a duplicated yml property, and also moved it to the main config file so it's easier to manage.

https://github.com/aspnet/Benchmarks/commit/d43ac9de16befc82370edafc30c1a5db72eff127

CarnaViire commented 3 months ago

Mitigated in https://github.com/aspnet/Benchmarks/commit/22e22b1c7aa0dc856a4b744673c28949ad63f8a4, at least the pipeline starts now 😅

CarnaViire commented 3 months ago

The first benchmarks on the list are running ok, so I guess I can close the issue; I'll reopen if I see any problems in HttpClient benchmarks after the pipeline finishes.

CarnaViire commented 3 months ago

Something is still wrong with httpclient CI jobs, like some wrong variables used, reopening

sebastienros commented 3 months ago

Maybe related to https://github.com/dotnet/crank/pull/754 If the channel argument is not set it will default to Current and trigger an NRE. For net9 I usually set Latest.

CarnaViire commented 2 months ago

HttpClient benchmarks are running again 🤞 (Also, server is temporarily pinned to use .net 8; client is running on 9.0 normally)

CarnaViire commented 2 months ago

Extracted the 9.0 server problem into a separate issue; since the benchmarks are running now, I'll close this one.