TaskHelpers_WaitWithTimeout_ReturnsTimeoutResultIfTaskNotComplete fails on xplat

aspnet / BrowserLink

Browser Link loader for Visual Studio integration

Apache License 2.0

17 stars 21 forks source link

TaskHelpers_WaitWithTimeout_ReturnsTimeoutResultIfTaskNotComplete fails on xplat #43

Open pranavkm opened 7 years ago

pranavkm commented 7 years ago

[xUnit.net 00:00:03.9067481]     Microsoft.VisualStudio.Web.BrowserLink.TaskHelpersTest.TaskHelpers_WaitWithTimeout_ReturnsTimeoutResultIfTaskNotComplete [FAIL]
[xUnit.net 00:00:03.9089484]       Task did not time out
Test Run Failed.

[xUnit.net 00:00:03.9092846]       Expected: True
[xUnit.net 00:00:03.9094667]       Actual:   False
[xUnit.net 00:00:03.9105680]       Stack Trace:

@YangLyu89, I'll skip it on xplat for now. Feel free to investigate it.

JunTaoLuo commented 7 years ago

This test is also flaky on Windows machines. I have seen failures on Win2008 and Win2012

JunTaoLuo commented 7 years ago

Skipping in https://github.com/aspnet/BrowserLink/commit/e270041fa1c8a83a973f8a513b03daacb9925618 Please investigate the test failure and re-enable.

Eilon commented 6 years ago

@jodavis - does anyone need to take a look at this issue? Are we missing important coverage because this test is disabled?

jodavis commented 6 years ago

No, we're not missing important coverage. It's probably not a product issue, just that the timeout needs to be increased to account for weird task timing in the test runner. I'll have someone fix it soon.