aspnet / BrowserLink

Browser Link loader for Visual Studio integration
Apache License 2.0
17 stars 21 forks source link

Browserlink & React template #86

Open wh1sp3r opened 5 years ago

wh1sp3r commented 5 years ago

Hi,

I found a problem with browserlink. Using browserlink shows "System.ObjectDisposedException: The response has been aborted due to an unhandled application exception. ---> System.FormatException: Invalid ETag name"

Repo:

  1. Create Asp net core website
  2. Select React template
  3. Install browserlink from nugget
  4. Add app.UseBrowserlink() into configure method
  5. Run and access the page.
nesherhh commented 5 years ago

I can confirm. Weak ETags are not handled correctly. Here is the stack trace.

Microsoft.Net.Http.Headers.dll!Microsoft.Net.Http.Headers.EntityTagHeaderValue.EntityTagHeaderValue(Microsoft.Extensions.Primitives.StringSegment tag, bool isWeak) Line 57 Microsoft.Net.Http.Headers.dll!Microsoft.Net.Http.Headers.EntityTagHeaderValue.EntityTagHeaderValue(Microsoft.Extensions.Primitives.StringSegment tag) Line 37 Microsoft.VisualStudio.Web.BrowserLink.dll!Microsoft.VisualStudio.Web.BrowserLink.BrowserLinkMiddleWareUtil.AddToETag(Microsoft.AspNetCore.Http.Headers.ResponseHeaders responseHeader, int port) Line 82 Microsoft.VisualStudio.Web.BrowserLink.dll!Microsoft.VisualStudio.Web.BrowserLink.BrowserLinkMiddleware.ExecuteWithFilter.AnonymousMethod__0() Line 109

swythan commented 3 years ago

I can confirm I had the same problem with the .Net 5.0 "ASP.Net Core + Angular" template with BrowserLink in VS2019.

mrjfalk commented 3 years ago

I'm also running into the same issue in ASP.Net Core + Angular. Is there a workaround available yet?