Revisit health check logging

aspnet / Diagnostics

[Archived] Diagnostics middleware for reporting info and handling exceptions and errors in ASP.NET Core, and diagnosing Entity Framework Core migrations errors. Project moved to https://github.com/aspnet/AspNetCore

Apache License 2.0

213 stars 111 forks source link

Revisit health check logging #472

Closed rynowak closed 5 years ago

rynowak commented 6 years ago

Looking through some other PRs, I realize that we haven't yet reviewed what health checks does for logging. We need to consider how we want this logging experience to work when health checks fail.

Topics:

[x] We log the individual health check results but nothing for the overall status
[x] Should we log different depending on the health status?
[x] Should we add additional log message for the detailed status data returned for each check?

rynowak commented 6 years ago

Some progress in: https://github.com/aspnet/Diagnostics/pull/486

Still need to make a decision about whether we log higher verbosity when health checks fail.

rynowak commented 5 years ago

Discussed with @glennc - going to make this an error

rynowak commented 5 years ago

https://github.com/aspnet/Diagnostics/pull/496