aspnet / Diagnostics

[Archived] Diagnostics middleware for reporting info and handling exceptions and errors in ASP.NET Core, and diagnosing Entity Framework Core migrations errors. Project moved to https://github.com/aspnet/AspNetCore
Apache License 2.0
213 stars 108 forks source link

Health Check service should not catch exceptions caused by cancellation #480

Closed rynowak closed 6 years ago

rynowak commented 6 years ago

The Health Check service currently catches all exceptions when executing a check, but we don't allow exceptions due to cancellation to propagate. Since we flow a cancellation token, we need to allow you to cancel 👍

rynowak commented 6 years ago

Fixed by https://github.com/aspnet/Diagnostics/pull/482