aspnet / Diagnostics

[Archived] Diagnostics middleware for reporting info and handling exceptions and errors in ASP.NET Core, and diagnosing Entity Framework Core migrations errors. Project moved to https://github.com/aspnet/AspNetCore
Apache License 2.0
213 stars 108 forks source link

Add EFCore DbContext check #487

Closed rynowak closed 6 years ago

rynowak commented 6 years ago

First draft of a DbContext-based EFCore health check - the sample is probably the best place to start.

rynowak commented 6 years ago

but looking at this I wonder if you really need to use IOptionsMonitor.

I thought IOptionsMonitor was the way to do named options? 🤷‍♂️

divega commented 6 years ago

but looking at this I wonder if you really need to use IOptionsMonitor.

I thought IOptionsMonitor was the way to do named options? 🤷‍♂️

Maybe. As I said, I don’t remember enough. @haok?

HaoK commented 6 years ago

Yeah no other way to do named options other than IOptionsMonitor, looks fine to me

rynowak commented 6 years ago

Cool, thanks friends!

rynowak commented 6 years ago

Will need to wait to add packages to aspnet/Universe before merging 😲