search

aspnet / Diagnostics

[Archived] Diagnostics middleware for reporting info and handling exceptions and errors in ASP.NET Core, and diagnosing Entity Framework Core migrations errors. Project moved to https://github.com/aspnet/AspNetCore
Apache License 2.0
213 stars 111 forks source link

Added execution time duration (HealthReportEntry TotalDuration) #493

Closed unaizorrilla closed 5 years ago

unaizorrilla commented 5 years ago

Hi @rynowak

This is the PR related with the issue #491.

HealthReport total duration is setted using the totaltime you mentioned on the issue, my only doubt is whether this time should not be aggregated from the report entry times.

Thanks

rynowak commented 5 years ago

HealthReport total duration is setted using the totaltime you mentioned on the issue, my only doubt is whether this time should not be aggregated from the report entry times.

I think defining the total time as "the time the health check service took to execute" vs "the sum of all health check timings" is the right decision. This will help users keep us honest, and if we manage to introduce significant overheads in this service it will be obvious.