Adjust font-weight to make it easier to read

aspnet / Diagnostics

[Archived] Diagnostics middleware for reporting info and handling exceptions and errors in ASP.NET Core, and diagnosing Entity Framework Core migrations errors. Project moved to https://github.com/aspnet/AspNetCore

Apache License 2.0

213 stars 111 forks source link

Adjust font-weight to make it easier to read #501

Closed 06b closed 5 years ago

06b commented 5 years ago

Personally I've found the developer exception page can be hard to read with the really thin font-weight even with 20/20 vision.

Below is an example of the default on a 1.5 device pixel ratio screen for chrome, edge & firefox. chromeedgefirefox-1_5dppx-default

Below is a screenshot with what I'm suggesting with this pull request. chromeedgefirefox-1_5dppx-code_fontweight600-h1h2h3h4h5_fontweight400

Obviously with different people, devices, browsers, fonts, settings, etc - this can be considered subjective, so if you think I should create an issue on the Home repo to get other people's feedback, let me know.

I also removed the commented out declaration.

Eilon commented 5 years ago

This does look a lot nicer! I could never pinpoint why I found it so hard to read the stack traces... but it's those thin, wiry fonts!

Eilon commented 5 years ago

@mkArtakMSFT can you assign someone to review & merge? I'm a fan of this change.

mccoyrjm commented 5 years ago

Much easier to read, supporting this!

natemcmaster commented 5 years ago

This looks like something we should get merged. The code for this project has moved to https://github.com/aspnet/AspNetCore/blob/master/src/Middleware/Diagnostics/src/DeveloperExceptionPage/Views/ErrorPage.css as a part of merging repos. Can you re-open this PR against the new location?

Thanks, Nate