Delay resolution until after application services are built

aspnet / Hosting

[Archived] Code for hosting and starting up an ASP.NET Core application. Project moved to https://github.com/aspnet/Extensions and https://github.com/aspnet/AspNetCore

Apache License 2.0

552 stars 312 forks source link

Delay resolution until after application services are built #1553

Closed davidfowl closed 5 years ago

davidfowl commented 5 years ago

Resolve the logger from the right service provider to log duplicate hosting startup assemblies.
Don't create a 3rd IServiceProvider if we resolved the default implementation.

This fixes logger being resolved too early:

Before

Notice the 2 console logger threads.

After

NOTE: This is still possible if you resolve the ILoggerFactory or ILogger from your Startup constructor.

Tratcher commented 5 years ago

release/2.2?