search

aspnet / HttpAbstractions

[Archived] HTTP abstractions such as HttpRequest, HttpResponse, and HttpContext, as well as common web utilities. Project moved to https://github.com/aspnet/AspNetCore
Apache License 2.0
382 stars 193 forks source link

[NoMerge] React to StringValues #1010

Closed benaadams closed 6 years ago

benaadams commented 6 years ago

Isn't it only HeaderDictionary that needs the change to not add nulls to the dictionary in the IDictionary path as it does in the IHeaderDictionary path?

Also needs https://github.com/aspnet/Common/pull/330

/cc @Tratcher @ryanbrandenburg @dougbu @rynowak @halter73

benaadams commented 6 years ago

e.g. currently its saying there is a header; then returning null; whereas it should say there isn't a header

ryanbrandenburg commented 6 years ago

Looks like the tests fail with this change.

benaadams commented 6 years ago

Looks like the tests fail with this change.

Also needs aspnet/Common#330

benaadams commented 6 years ago

I can put a fix in (e.g. put .ToArray(); back), then revert after?

benaadams commented 6 years ago

Added fix back

Tratcher commented 6 years ago

Heads up, the original change was reverted. We'll reintroduce it more cautiously by doing full universe builds before merging.

muratg commented 6 years ago

We’re closing this PR because we don’t feel that this change is a good fit for the product at this time.

We thank you for the contribution and look forward to collaborating more in the future.