Renable auth tests with new HttpClient

aspnet / HttpSysServer

[Archived] A web server for ASP.NET Core based on the Windows Http Server API. Project moved to https://github.com/aspnet/AspNetCore

Apache License 2.0

106 stars 39 forks source link

Renable auth tests with new HttpClient #444

Closed Tratcher closed 6 years ago

Tratcher commented 6 years ago

We took an updated SocketsHttpHandler that fixed the regression in #439.

Also, now that SocketsHttpHandler is the default in 2.1 https://github.com/aspnet/ServerTests/issues/82 is no longer a problem. Using #ifdef so these are now enabled on NETCOREAPP2.1 and NET461 and disabled on NETCOREAPP2.0.

jkotalik commented 6 years ago

Seems to be a few appveyor failures.

Tratcher commented 6 years ago

None of them are the tests we changed. Looks like HttpSys is very flaky on AppVeyor. Re-running.

jkotalik commented 6 years ago

What differences could there be between AppVeyor and our ci for these tests?

Tratcher commented 6 years ago

We'll work on the flaky tests independently.