search

aspnet / HttpSysServer

[Archived] A web server for ASP.NET Core based on the Windows Http Server API. Project moved to https://github.com/aspnet/AspNetCore
Apache License 2.0
106 stars 39 forks source link

#364 - Expose HTTP_503_RESPONSE_VERBOSITY option #447

Closed FabianMeiswinkel closed 6 years ago

FabianMeiswinkel commented 6 years ago

Changes discussed offline with Chris earlier this morning to expose Http503ResponseVebosityLevel. Feature request tracked in the backlog already under: https://github.com/aspnet/HttpSysServer/issues/364 https://msdn.microsoft.com/en-us/library/windows/desktop/aa364509(v=vs.85).aspx

I am submitting this to get unblocked for the migration of our UniversalStore services from Owin/Katana + WebApi 2.0 to Asp.Net Core

dnfclas commented 6 years ago

CLA assistant check
All CLA requirements met.

Tratcher commented 6 years ago

@shirhatti recommended for rc1.

shirhatti commented 6 years ago

Looks good. We can take it.

Just curious, what does the response look like for Http503ResponseVerbosityFull?

FabianMeiswinkel commented 6 years ago

A 503 and the body is the ugly and messy hard-coded HTML IIS sometimes returned on legacy Asp.Net.

FabianMeiswinkel commented 6 years ago

And the literal const is actually the following (at least in english). This text varies depending on which throttle was hit.

<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.01//EN""http://www.w3.org/TR/html4/strict.dtd">

Service Unavailable

Forbidden - Too Many Users

HTTP Error 503. There are too many outstanding connections.

Sent from Mailhttps://go.microsoft.com/fwlink/?LinkId=550986 for Windows 10

From: Fabian Meiswinkel Sent: Tuesday, April 10, 2018 8:49:24 PM To: aspnet/HttpSysServer; aspnet/HttpSysServer Cc: Author Subject: RE: [aspnet/HttpSysServer] #364 - Expose HTTP_503_RESPONSE_VERBOSITY option (#447)

A 503 and the body is the ugly and messy hard-coded HTML IIS sometimes returned on legacy Asp.Net.

Sent from Mailhttps://go.microsoft.com/fwlink/?LinkId=550986 for Windows 10

From: Sourabh Shirhatti notifications@github.com Sent: Tuesday, April 10, 2018 8:48:18 PM To: aspnet/HttpSysServer Cc: Fabian Meiswinkel; Author Subject: Re: [aspnet/HttpSysServer] #364 - Expose HTTP_503_RESPONSE_VERBOSITY option (#447)

Looks good. We can take it.

Just curious, what does the response look like for Http503ResponseVerbosityFull?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHubhttps://github.com/aspnet/HttpSysServer/pull/447#issuecomment-380207816, or mute the threadhttps://github.com/notifications/unsubscribe-auth/ASRvVu1v88QjG8QN3ehl4cX6MHsYt8F_ks5tnP5ygaJpZM4TOqTn.