UseHttpSys against IServiceCollection to support generic host

aspnet / HttpSysServer

[Archived] A web server for ASP.NET Core based on the Windows Http Server API. Project moved to https://github.com/aspnet/AspNetCore

Apache License 2.0

106 stars 39 forks source link

UseHttpSys against IServiceCollection to support generic host #448

Closed chuanboz closed 5 years ago

chuanboz commented 6 years ago

see https://github.com/aspnet/KestrelHttpServer/issues/2498 for Kestrel.

similar issue exists for UseHttpSys, and it's even harder as MessagePump class is marked as internal.

' public static IServiceCollection UseHttpSys(this IServiceCollection services) { services.AddSingleton<IServer, MessagePump>(); services.AddAuthenticationCore(); return services; } '

muratg commented 5 years ago

Design around this has changed. We don't need this anymore.

chuanboz commented 5 years ago

thanks @muratg , do you have a link to the changed design around this? just trying to understand the latest design better.

Tratcher commented 5 years ago

See https://github.com/aspnet/Hosting/pull/1580