Flaky test: ResponseBody_SecondWriteAsyncWithCanceledCancellationToken_CancelsAndAborts

ryanbrandenburg commented 6 years ago

This test fails occasionally with the following error:

Assert.Throws() Failure
Expected: typeof(System.Net.Http.HttpRequestException)
Actual:   typeof(System.Threading.Tasks.TaskCanceledException): A task was canceled.
   at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess(Task task)
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
   at System.Net.Http.HttpClient.<FinishSendAsyncBuffered>d__58.MoveNext()
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess(Task task)
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
   at Microsoft.AspNetCore.Server.HttpSys.Listener.ResponseBodyTests.<SendRequestAsync>d__24.MoveNext()
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess(Task task)
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)

ryanbrandenburg commented 6 years ago

ResponseBody_SecondWriteAsyncWithCanceledCancellationToken_CancelsAndAborts failed again.

This comment was made automatically. If there is a problem contact @ryanbrandenburg.

ryanbrandenburg commented 6 years ago

ResponseBody_SecondWriteAsyncWithCanceledCancellationToken_CancelsAndAborts failed with about the same error.

This comment was made automatically. If there is a problem contact @ryanbrandenburg.

ryanbrandenburg commented 6 years ago

ResponseBody_WriteContentLengthTooMuchWritten_Throws failed with about the same error on master.

This comment was made automatically. If there is a problem contact ryanbrandenburg.

aspnet-hello commented 6 years ago

ResponseBody_WriteContentLengthNotEnoughWritten_Aborts failed with about the same error on master.

This comment was made automatically. If there is a problem contact ryanbrandenburg.

aspnet-hello commented 6 years ago

Caching_InvalidExpires_NotCached failed with about the same error on master. ResponseBody_WriteContentLengthTooMuchWritten_Throws failed with about the same error on master.

This comment was made automatically. If there is a problem contact ryanbrandenburg.

aspnet-hello commented 6 years ago

AuthTypes_AllowAnonymous_NoChallenge failed with about the same error on master. ResponseBody_SecondWriteAsyncWithCanceledCancellationToken_CancelsAndAborts failed with about the same error on 2.2.

This comment was made automatically. If there is a problem contact ryanbrandenburg.

aspnet-hello commented 6 years ago

AuthTypes_AllowAnonymous_NoChallenge failed with about the same error on master.

This comment was made automatically. If there is a problem contact ryanbrandenburg.

aspnet-hello commented 6 years ago

ResponseBody_SecondWriteAsyncWithCanceledCancellationToken_CancelsAndAborts failed with about the same error on 2.2.

This comment was made automatically. If there is a problem contact ryanbrandenburg.

aspnet-hello commented 6 years ago

AuthTypes_AllowAnonymous_NoChallenge failed with about the same error on master.

This comment was made automatically. If there is a problem contact ryanbrandenburg.

aspnet-hello commented 6 years ago

AuthTypes_AllowAnonymous_NoChallenge failed with about the same error on master.

This comment was made automatically. If there is a problem contact ryanbrandenburg.

aspnet-hello commented 6 years ago

Caching_InvalidExpires_NotCached failed with about the same error on master.

This comment was made automatically. If there is a problem contact ryanbrandenburg.

aspnet-hello commented 6 years ago

AuthTypes_AllowAnonymous_NoChallenge failed with about the same error on master.

This comment was made automatically. If there is a problem contact ryanbrandenburg.

aspnet-hello commented 6 years ago

ResponseBody_WriteContentLengthNotEnoughWritten_Aborts failed with about the same error on master.

This comment was made automatically. If there is a problem contact ryanbrandenburg.

ryanbrandenburg commented 6 years ago

@muratg this fails every couple of days or so, can we get it looked into?

aspnet-hello commented 6 years ago

Caching_InvalidExpires_NotCached failed with about the same error on master.

This comment was made automatically. If there is a problem contact ryanbrandenburg. There were 1 failures with about the same error on master: Caching_InvalidExpires_NotCached

aspnet-hello commented 6 years ago

There were 1 failures with about the same error on master:

ResponseBody_WriteContentLengthNotEnoughWritten_Aborts

This comment was made automatically. If there is a problem contact ryanbrandenburg.

aspnet-hello commented 6 years ago

There were 1 failures with about the same error on master:

Caching_InvalidExpires_NotCached

This comment was made automatically. If there is a problem contact ryanbrandenburg.

aspnet-hello commented 6 years ago

This comment was made automatically. If there is a problem contact ryanbrandenburg.

There were 1 failures with about the same error on master at 3:17:24 PM:

ResponseBodyWriteExceptions_SecondWriteAsyncWithCanceledCancellationToken_CancelsAndAborts

aspnet-hello commented 6 years ago

This comment was made automatically. If there is a problem contact ryanbrandenburg.

There were 2 failures with about the same error on master at 2:30:59 PM:

ResponseBody_SecondWriteAsyncWithCanceledCancellationToken_CancelsAndAborts
AuthTypes_AllowAnonymous_NoChallenge

aspnet-hello commented 6 years ago

This comment was made automatically. If there is a problem contact ryanbrandenburg.

There were 1 failures with about the same error on master at 9:35:49 PM:

Caching_InvalidExpires_NotCached

aspnet-hello commented 6 years ago

This comment was made automatically. If there is a problem contact ryanbrandenburg.

There were 1 failures with about the same error on master at 7:48:32 PM:

AuthTypes_AllowAnonymous_NoChallenge

There were 1 failures with about the same error on master at 7:08:25 AM:

Caching_InvalidExpires_NotCached

aspnet-hello commented 6 years ago

This comment was made automatically. If there is a problem contact ryanbrandenburg.

There were 1 failures with about the same error on master at 1:47:34 PM:

Caching_InvalidExpires_NotCached

aspnet-hello commented 6 years ago

This comment was made automatically. If there is a problem contact ryanbrandenburg.

There were 1 failures with about the same error on 2.2 at 8:24:44 PM:

ResponseBody_WriteContentLengthTooMuchWritten_Throws

There were 1 failures with about the same error on master at 10:53:03 AM:

Caching_InvalidExpires_NotCached

aspnet-hello commented 6 years ago

This comment was made automatically. If there is a problem contact ryanbrandenburg.

There were 1 failures with about the same error on master at 6:38:10 PM:

AuthTypes_AllowAnonymous_NoChallenge

aspnet-hello commented 6 years ago

This comment was made automatically. If there is a problem contact ryanbrandenburg.

There were 1 failures with about the same error on master at 2:33:07 PM:

AuthTypes_AllowAnonymous_NoChallenge

aspnet-hello commented 6 years ago

This comment was made automatically. If there is a problem contact ryanbrandenburg.

There were 1 failures with about the same error on master at 9:35:28 PM:

AuthTypes_AllowAnonymous_NoChallenge

There were 1 failures with about the same error on master at 1:50:48 PM:

AuthTypes_AllowAnonymous_NoChallenge

aspnet-hello commented 6 years ago

This comment was made automatically. If there is a problem contact ryanbrandenburg.

There were 1 failures with about the same error on master at 8:14:37 PM:

AuthTypes_AllowAnonymous_NoChallenge

aspnet-hello commented 6 years ago

This comment was made automatically. If there is a problem contact ryanbrandenburg.

There were 1 failures with about the same error on master at 8:37:02 PM:

ResponseBody_SecondWriteAsyncWithCanceledCancellationToken_CancelsAndAborts

There were 2 failures with about the same error on master at 11:02:02 AM:

RequestBody_ReadAsyncPartialBodyAndExpiredTimeout_Canceled
ResponseBody_SecondWriteAsyncWithCanceledCancellationToken_CancelsAndAborts

Tratcher commented 6 years ago

ResponseBody_SecondWriteAsyncWithCanceledCancellationToken_CancelsAndAborts 2 failures

10643 Win 2012, .NET 4.6.1 only.
10557, 2008 R2, net461

Note this is a Listener style test that should be re-written.

Edit: 16 more failures further back in the history that for some reason TC wasn't grouping. Looks like changes to the TC layout disrupt the test history. http://aspnetci/project.html?projectId=XPlat&buildTypeId=&tab=testDetails&testNameId=5683730871270455385&order=TEST_STATUS_DESC&branch_XPlat=__all_branches__&itemsCount=50 http://aspnetci/project.html?projectId=Releases_22xPublic&buildTypeId=&tab=testDetails&testNameId=5683730871270455385&order=TEST_STATUS_DESC&branch_Releases_22xPublic=__all_branches__&itemsCount=50

Same results as above spread across all Windows OS versions, SKUs, branches, etc..

ResponseBodyWriteExceptions_SecondWriteAsyncWithCanceledCancellationToken_CancelsAndAborts looks the same.

Tratcher commented 6 years ago

Everything above has been resolved except Caching_InvalidExpires_NotCached and the issue described in the prior post.

Caching_InvalidExpires_NotCached:

Win7 and 2008 R2 only.
All failures are on the "0" theory version of the test.
All failures are timeouts.
All failures are on the non-Listener version of tests that are in theory more reliable.
netcoreapp2.2 failures only

No repro locally.

aspnet-hello commented 6 years ago

This comment was made automatically. If there is a problem contact ryanbrandenburg.

There were 1 failures with about the same error on master at 1:59:59 AM:

RequestBody_ReadAsyncPartialBodyAndExpiredTimeout_Canceled

Tratcher commented 6 years ago

Closing this out. Fixes or mitigations have been added for all failures.

aspnet / HttpSysServer

Flaky test: ResponseBody_SecondWriteAsyncWithCanceledCancellationToken_CancelsAndAborts #451