search

aspnet / HttpSysServer

[Archived] A web server for ASP.NET Core based on the Windows Http Server API. Project moved to https://github.com/aspnet/AspNetCore
Apache License 2.0
106 stars 39 forks source link

Error log message contains wrong class and method name #467

Closed MHHenriksen closed 5 years ago

MHHenriksen commented 6 years ago

https://github.com/aspnet/HttpSysServer/blob/5edeb8c2ab2d9ee11aa1fe0fb6d928088675ed49/src/Microsoft.AspNetCore.Server.HttpSys/RequestProcessing/ResponseBody.cs#L131

The log message says "ResponseStream::Dispose" while the class is actually named ResponseBody.

MHHenriksen commented 6 years ago

Actually, the method name is wrong too, since it's logged from FlushInternal, even though it will only happen during Dispose since endOfRequest is only true when called from there.

muratg commented 5 years ago

@MHHenriksen if you're still interested please send a PR. Thanks.