search

aspnet / HttpSysServer

[Archived] A web server for ASP.NET Core based on the Windows Http Server API. Project moved to https://github.com/aspnet/AspNetCore
Apache License 2.0
106 stars 39 forks source link

Disable flaky test on Win7/Win2008 #473

Closed JunTaoLuo closed 5 years ago

JunTaoLuo commented 6 years ago

Addresses https://github.com/aspnet/HttpSysServer/issues/468. This test is only flaky on Win7 and Win2008 and it looks like it's failing inside HttpClient. I don't think it's worth the time to rewrite the test to be more robust. I think it's sufficient to disable these test on the older systems and keep them running on everything Win8 and newer.

JunTaoLuo commented 6 years ago

@natemcmaster is 2.1 servicing prodcon builds dependent on the tests passing on downstream OS such as Win7 and Win2008? IIRC they shouldn't be so I don't plan on porting this change to 2.1. If they are, then I'll open a separate PR for the servicing branch and go through the approval process once this PR is approved.

natemcmaster commented 6 years ago

Failing test runs never block us from getting builds. That said, it's still ideal to fix test failures in servicing releases. It helps us better evaluate if changes in servicing branches cause regressions.

JunTaoLuo commented 6 years ago

ping

Tratcher commented 6 years ago

No failures reported in 24 days, why bother disabling it?

JunTaoLuo commented 6 years ago

Right but the underlying issue has not been solved. It's an infrequent failure but there's evidence that it remains flaky.

Tratcher commented 6 years ago

What evidence? I don't see anything in the last 24 days.