search

aspnet / Identity

[Archived] ASP.NET Core Identity is the membership system for building ASP.NET Core web applications, including membership, login, and user data. Project moved to https://github.com/aspnet/AspNetCore
Apache License 2.0
1.96k stars 868 forks source link

Switch to abstract user factory #1743

Closed HaoK closed 6 years ago

HaoK commented 6 years ago

Part of https://github.com/aspnet/Identity/issues/1722

javiercn commented 6 years ago

@HaoK Can we press pause on this? I don't want to rush https://github.com/aspnet/Identity/issues/1722 in 2.1 as the scope is much bigger and we need time to properly bake it in,

The requirement for 2.1 is that you can use a custom TUser with the default Identity UI. I agreed to get this in for preview2, but I wanted us to revisit it on RC and discuss alternatives.

Can we setup a meeting to discuss this?

HaoK commented 6 years ago

Sure we can discuss, but going with an abstract base class should mean that we can fix #1722 however we want later since it won't be a breaking change to add new methods to the base class

HaoK commented 6 years ago

I don't think we should try and actually do the full on thing in 2.1 at all

javiercn commented 6 years ago

Close? @HaoK