Fix ActivePage declarations

aspnet / Identity

[Archived] ASP.NET Core Identity is the membership system for building ASP.NET Core web applications, including membership, login, and user data. Project moved to https://github.com/aspnet/AspNetCore

Apache License 2.0

1.96k stars 869 forks source link

Fix ActivePage declarations #1838

Closed tstivers1990 closed 6 years ago

tstivers1990 commented 6 years ago

Some of the ViewData["ActivePage"] declarations were missing.
DeletePersonalData and DownloadPersonalData should set ActivePage to PersonalData as there is no navigation element for DeletePersonalData or DownloadPersonalData.
Remove DeletePersonalData and DownloadPersonalData variables and methods as they're no longer used by anthing.
Make PageNavClass private as it is never used outside of its class.

dnfclas commented 6 years ago

All CLA requirements met.

tstivers1990 commented 6 years ago

The TwoFactorAuthentication page was also missing the ActivePage assignment. I've added that in the latest commit.

HaoK commented 6 years ago

@javiercn do these changes look reasonable to you?

javiercn commented 6 years ago

Thanks for contacting us @tstivers1990 Could you please file or point the PR to an issue describing the problem and what the proposed changes do (What's the visual before/after)

tstivers1990 commented 6 years ago

See #1866

tstivers1990 commented 6 years ago

The breaking changes should be removed.

javiercn commented 6 years ago

Merged! Thanks for your contribution!