ConfirmEmailAsync in UserManager is not doing a check if the email is already confirmed

aspnet / Identity

[Archived] ASP.NET Core Identity is the membership system for building ASP.NET Core web applications, including membership, login, and user data. Project moved to https://github.com/aspnet/AspNetCore

Apache License 2.0

1.96k stars 870 forks source link

ConfirmEmailAsync in UserManager is not doing a check if the email is already confirmed #1861

Closed zhulien-ivanov closed 6 years ago

zhulien-ivanov commented 6 years ago

Hey. Shouldn't the ConfirmEmailAsync method in UserManager do a check if the email is already confirmed? Is it an adequate behaviour to successfully confirm an already confirmed email? It basically don't change the outcome in any way(and the operation can be considered as successful), because the email confirmation state stays the same, but shouldn't it be considered an exceptional behaviour and be accompanied with an error?

blowdart commented 6 years ago

No. You have the IsEmailConfirmedAsync method to check with. If you're calling ConfirmEmailAsync we're going to do what the method indicates, send a confirmation notice.