search

aspnet / Identity

[Archived] ASP.NET Core Identity is the membership system for building ASP.NET Core web applications, including membership, login, and user data. Project moved to https://github.com/aspnet/AspNetCore
Apache License 2.0
1.96k stars 868 forks source link

Fix provider display name #1899

Closed thomaslevesque closed 6 years ago

thomaslevesque commented 6 years ago

Fixes #1892

HaoK commented 6 years ago

Looks good overall, do you want to try and take a stab at adding a functional test for the UI changes?

Would probably go in here https://github.com/aspnet/Identity/blob/master/test/Identity.FunctionalTests/ManagementTests.cs#L169 with a slightly different flow that just verifies that the Display name is different for the UI renderings, you would have to change the display name as well for Contoso here:

https://github.com/aspnet/Identity/blob/master/test/WebSites/Identity.DefaultUI.WebSite/Services/ContosoAuthenticationConstants.cs#L9

thomaslevesque commented 6 years ago

@HaoK sure, I'll give it a try.

thomaslevesque commented 6 years ago

@HaoK I tried something, but I'm not very happy with it. It seems a bit brittle to examine the HTML like this. Is this the kind of test you were expecting?

HaoK commented 6 years ago

Thanks merged via 6b257f0abbbe6938c0712b9a8e00b85131ed51d5

thomaslevesque commented 6 years ago

Thanks @HaoK