Closed ryanbrandenburg closed 6 years ago
Please use this workflow to address this flaky test issue, including checking applicable checkboxes and filling in the applicable "TODO" entries:
Is this actually a flaky test?
Is this test failure caused by product code flakiness? (Either this product, or another product this test depends on.)
Is it that the test itself is flaky? This includes external transient problems (e.g. remote server problems, file system race condition, etc.)
This comment was made automatically. If there is a problem contact @ryanbrandenburg.
@ryanbrandenburg which branch of the if statement would this go if it appears to be Moq itself being flaky here. This is failing inside of this, there's basically nothing going on here
var store = new Mock<IUserStore<TUser>>();
var mgr = new Mock<UserManager<TUser>>(store.Object, null, null, null, null, null, null, null, null);
That would be either
No, this is a regular test failure, fix the test/product (TODO: Link to commit/PR)
or
Is this test failure caused by product code flakiness? (Either this product, or another product this test depends on.)
depending on if it's flaky or not.
Ok filed an issue with moq, do I leave this open or close this bug as external?
Recommendation from moq is that we upgrade to 4.9 which might fix this issue.
Leave this bug open to track the external issue. Also because otherwise the bot will open one identical to it the next time it fails.
EnsureClaimsIdentityHasExpectedClaims failed with about the same error on master.
This comment was made automatically. If there is a problem contact ryanbrandenburg.
@natemcmaster I verified that identity seems fine when bumping up my local dependencies.props version of moq to 4.9.0.
Should I submit a PR to universe bumping up the version here https://github.com/aspnet/Universe/blob/master/build/dependencies.props#L126 ? Or is there some other steps that also are needed to upgrade moq to 4.9.0?
yes, submit a PR to Universe. We'll probably run a build with this change first to make sure Moq 4.9 still works on our many other test projects.
This test fails occasionally with the following error:
Other tests within that build may have failed with a similar message, but they are not listed here. Check the link above for more info.
CC @Eilon,@muratg,@mkArtakMSFT
This issue was made automatically. If there is a problem contact @ryanbrandenburg.