Merge release 2.2 -> master

aspnet / Identity

[Archived] ASP.NET Core Identity is the membership system for building ASP.NET Core web applications, including membership, login, and user data. Project moved to https://github.com/aspnet/AspNetCore

Apache License 2.0

1.96k stars 869 forks source link

Merge release 2.2 -> master #1921

Closed HaoK closed 6 years ago

HaoK commented 6 years ago

Manual merge replacing automated PR

cc @natemcmaster

natemcmaster commented 6 years ago

Travis and VSTS are failing.

HaoK commented 6 years ago

Yeah those failures are not new, vsts is the EF time out issue. I'm not sure exactly why travis is failing in one instance, but it was failing in the other PRs as well.

natemcmaster commented 6 years ago

We should really get to the bottom of this. From @smitpatel's last comment on https://github.com/aspnet/EntityFrameworkCore/issues/12842, it appears that EF's async tests can deadlock. Is Identity doing a bunch of async queries in EF?

HaoK commented 6 years ago

Yeah tons of async queries