Test failure: CanLogInWithTwoFactorAuthentication_WithGlobalAuthorizeFilter

[ryanbrandenburg]

This test fails occasionally with the following error:

System.IO.IOException : Undefined error: 0
   at System.IO.FileSystemWatcher.RunningInstance.Start()
   at System.IO.FileSystemWatcher.StartRaisingEvents()
   at System.IO.FileSystemWatcher.StartRaisingEventsIfNotDisposed()
   at System.IO.FileSystemWatcher.set_EnableRaisingEvents(Boolean value)
   at Microsoft.Extensions.FileProviders.Physical.PhysicalFilesWatcher.TryEnableFileSystemWatcher()
   at Microsoft.Extensions.FileProviders.Physical.PhysicalFilesWatcher.CreateFileChangeToken(String filter)
   at Microsoft.AspNetCore.Mvc.RazorPages.Internal.PageActionDescriptorChangeProvider.GetChangeToken()
   at Microsoft.Extensions.Primitives.ChangeToken.OnChange(Func`1 changeTokenProducer, Action changeTokenConsumer)
   at Microsoft.AspNetCore.Mvc.Internal.ActionDescriptorCollectionProvider..ctor(IEnumerable`1 actionDescriptorProviders, IEnumerable`1 actionDescriptorChangeProviders)
--- End of stack trace from previous location where exception was thrown ---
   at Microsoft.Extensions.DependencyInjection.ServiceLookup.CallSiteRuntimeResolver.VisitConstructor(ConstructorCallSite constructorCallSite, ServiceProviderEngineScope scope)
   at Microsoft.Extensions.DependencyInjection.ServiceLookup.CallSiteRuntimeResolver.VisitScoped(ScopedCallSite scopedCallSite, ServiceProviderEngineScope scope)
   at Microsoft.Extensions.DependencyInjection.ServiceLookup.CallSiteRuntimeResolver.VisitConstructor(ConstructorCallSite constructorCallSite, ServiceProviderEngineScope scope)
   at Microsoft.Extensions.DependencyInjection.ServiceLookup.CallSiteRuntimeResolver.VisitScoped(ScopedCallSite scopedCallSite, ServiceProviderEngineScope scope)
   at Microsoft.Extensions.DependencyInjection.ServiceLookup.CallSiteRuntimeResolver.VisitConstructor(ConstructorCallSite constructorCallSite, ServiceProviderEngineScope scope)
   at Microsoft.Extensions.DependencyInjection.ServiceLookup.CallSiteRuntimeResolver.VisitTransient(TransientCallSite transientCallSite, ServiceProviderEngineScope scope)
   at Microsoft.Extensions.DependencyInjection.ServiceLookup.CallSiteRuntimeResolver.VisitIEnumerable(IEnumerableCallSite enumerableCallSite, ServiceProviderEngineScope scope)
   at Microsoft.Extensions.DependencyInjection.ServiceLookup.CallSiteRuntimeResolver.VisitConstructor(ConstructorCallSite constructorCallSite, ServiceProviderEngineScope scope)
   at Microsoft.Extensions.DependencyInjection.ServiceLookup.CallSiteRuntimeResolver.VisitScoped(ScopedCallSite scopedCallSite, ServiceProviderEngineScope scope)
   at Microsoft.Extensions.DependencyInjection.ServiceLookup.CallSiteRuntimeResolver.VisitConstructor(ConstructorCallSite constructorCallSite, ServiceProviderEngineScope scope)
   at Microsoft.Extensions.DependencyInjection.ServiceLookup.CallSiteRuntimeResolver.VisitScoped(ScopedCallSite scopedCallSite, ServiceProviderEngineScope scope)
   at Microsoft.Extensions.DependencyInjection.ServiceProviderServiceExtensions.GetRequiredService(IServiceProvider provider, Type serviceType)
   at Microsoft.Extensions.DependencyInjection.ServiceProviderServiceExtensions.GetRequiredService[T](IServiceProvider provider)
   at Microsoft.AspNetCore.Builder.MvcApplicationBuilderExtensions.UseMvc(IApplicationBuilder app, Action`1 configureRoutes)
   at Identity.DefaultUI.WebSite.StartupBase`2.Configure(IApplicationBuilder app, IHostingEnvironment env)
--- End of stack trace from previous location where exception was thrown ---
   at Microsoft.AspNetCore.Hosting.ConventionBasedStartup.Configure(IApplicationBuilder app)
   at Microsoft.AspNetCore.Hosting.Internal.WebHost.BuildApplication()
   at Microsoft.AspNetCore.Hosting.Internal.WebHost.StartAsync(CancellationToken cancellationToken)
   at Microsoft.AspNetCore.TestHost.TestServer..ctor(IWebHostBuilder builder, IFeatureCollection featureCollection)
   at Microsoft.AspNetCore.Mvc.Testing.WebApplicationFactory`1.CreateServer(IWebHostBuilder builder)
   at Microsoft.AspNetCore.Mvc.Testing.WebApplicationFactory`1.EnsureServer()
   at Microsoft.AspNetCore.Mvc.Testing.WebApplicationFactory`1.CreateDefaultClient(DelegatingHandler[] handlers)
   at Microsoft.AspNetCore.Mvc.Testing.WebApplicationFactory`1.CreateClient(WebApplicationFactoryClientOptions options)
   at Microsoft.AspNetCore.Identity.FunctionalTests.LoginTests`2.CanLogInWithTwoFactorAuthentication_WithGlobalAuthorizeFilter()
--- End of stack trace from previous location where exception was thrown ---

Other tests within that build may have failed with a similar message, but they are not listed here. Check the link above for more info.

This test failed on 2.2.

CC @Eilon (because the bot doesn't know who else to pick)

This issue was made automatically. If there is a problem contact ryanbrandenburg.

[ryanbrandenburg]

Please use this workflow to address this flaky test issue, including checking applicable checkboxes and filling in the applicable "TODO" entries:

• Is this actually a flaky test?

  • No, this is a regular test failure, fix the test/product (TODO: Link to commit/PR)
  • Yes, proceed below...

• Is this test failure caused by product code flakiness? (Either this product, or another product this test depends on.)

  • [ ] File a bug against the product (TODO: Link to other bug)
  • Is it possible to change the test to avoid the flakiness?
  • Yes? Go to the "Change the test!" section.
  • No?
    • [ ] Disable the test (TODO: Link to PR/commit)
    • [ ] Wait for other bug to be resolved
    • [ ] Wait for us to get build that has the fix
    • [ ] Re-enable our test (TODO: Link to PR/commit)
    • [ ] Close this bug

• Is it that the test itself is flaky? This includes external transient problems (e.g. remote server problems, file system race condition, etc.)

  • Is there is a way to change our test to avoid this flakiness?
  • Yes? Change the test!
    • [ ] Change the test to avoid the flakiness, for example by using a different test strategy, or by adding retries w/ timeouts (TODO: Link to PR/commit)
    • [ ] Run the test 100 times locally as a sanity check.
    • [ ] Close this bug
  • No?
    • Is there any logging or extra information that we could add to make this more diagnosable when it happens again?
    • Yes?
      • [ ] Add the logging (TODO: Link to PR/commit)
    • No?
      • [ ] Delete the test because flaky tests are not useful (TODO: Link to PR/commit)

This comment was made automatically. If there is a problem contact ryanbrandenburg.

[ryanbrandenburg]

CanLogInWithTwoFactorAuthentication_WithGlobalAuthorizeFilter failed with about the same error on master. CanSetPasswordWithExternalLogin failed with about the same error on 2.2. CanLogInWithTwoFactorAuthentication_WithGlobalAuthorizeFilter failed with about the same error on master. CanLogInAfterConfirmingEmail failed with about the same error on 2.2.

This comment was made automatically. If there is a problem contact ryanbrandenburg.

[ryanbrandenburg]

CanSetPasswordWithExternalLogin failed with about the same error on 2.2. CanLogInWithTwoFactorAuthentication_WithGlobalAuthorizeFilter failed with about the same error on master. CanLogInWithTwoFactorAuthentication_WithGlobalAuthorizeFilter failed with about the same error on 2.2. CanSetPasswordWithExternalLogin failed with about the same error on master.

This comment was made automatically. If there is a problem contact ryanbrandenburg.

[ryanbrandenburg]

CanLogInWithTwoFactorAuthentication_WithGlobalAuthorizeFilter failed with about the same error on master. CanLogInWithTwoFactorAuthentication_WithGlobalAuthorizeFilter failed with about the same error on 2.2.

This comment was made automatically. If there is a problem contact ryanbrandenburg.

[ryanbrandenburg]

CanLogInWithTwoFactorAuthentication_WithGlobalAuthorizeFilter failed with about the same error on 2.2.

This comment was made automatically. If there is a problem contact ryanbrandenburg.

[aspnet-hello]

CanLogInWithTwoFactorAuthentication_WithGlobalAuthorizeFilter failed with about the same error on 2.2.

This comment was made automatically. If there is a problem contact ryanbrandenburg.

[aspnet-hello]

CanSetPasswordWithExternalLogin failed with about the same error on master. CanLogInWithTwoFactorAuthentication_WithGlobalAuthorizeFilter failed with about the same error on 2.2. CanLogInWithTwoFactorAuthentication_WithGlobalAuthorizeFilter failed with about the same error on master. CanLogInWithTwoFactorAuthentication_WithGlobalAuthorizeFilter failed with about the same error on 2.2.

This comment was made automatically. If there is a problem contact ryanbrandenburg.

[aspnet-hello]

CanLogInWithTwoFactorAuthentication_WithGlobalAuthorizeFilter failed with about the same error on master. CanLogInWithTwoFactorAuthentication_WithGlobalAuthorizeFilter failed with about the same error on master.

This comment was made automatically. If there is a problem contact ryanbrandenburg.

[aspnet-hello]

CanLogInWithTwoFactorAuthentication_WithGlobalAuthorizeFilter failed with about the same error on master.

This comment was made automatically. If there is a problem contact ryanbrandenburg.

[Eilon]

@mkArtakMSFT - can you assign? Call stack looks related to Razor Pages.

[aspnet-hello]

CanLogInWithTwoFactorAuthentication_WithGlobalAuthorizeFilter failed with about the same error on master.

This comment was made automatically. If there is a problem contact ryanbrandenburg.

[aspnet-hello]

CanLogInWithTwoFactorAuthentication_WithGlobalAuthorizeFilter failed with about the same error on master. CanLogInWithTwoFactorAuthentication_WithGlobalAuthorizeFilter failed with about the same error on master.

This comment was made automatically. If there is a problem contact ryanbrandenburg.

[ryanbrandenburg]

@mkArtakMSFT was this resolved? If so how? Please assign someone to find out.

[mkArtakMSFT]

@javiercn, can you please look into this and close if this is resolved already. Otherwise - just come up with a fix please.

[javiercn]

@pranavkm I think this is likely related to exhausting the number of file descriptors, but I think we took action for it. Didn’t we?

[javiercn]

I checked and it seems like we did. Given that all the views are precompiled. Would it be problematic if we remove all the file providers from razor view engine options? That way there wouldn’t be any file watching going on, based on what I see on DefaultRazorViewEngineFileProviderAccessor. Does that make sense @pranavkm

[pranavkm]

Would it be problematic if we remove all the file providers from razor view engine options?

Think the compiler throws if you have no fileproviders. You might have to hack it a bit. More specifically we don't watch for files in Release builds which is usually what exhausts file descriptors.

[javiercn]

@pranavkm would it be a problem if we just add a bogus one instead? The callstack looks pretty descriptive to me.

[pranavkm]

Adding a CompositeFileProvider that contains a single NullFileProvider might not throw. Highlighting the relevant pieces

• https://github.com/aspnet/Mvc/blob/release/2.2/src/Microsoft.AspNetCore.Mvc.Razor/Internal/DefaultRazorViewEngineFileProviderAccessor.cs#L21-L24
• https://github.com/aspnet/Mvc/blob/release/2.2/src/Microsoft.AspNetCore.Mvc.Razor/Internal/RazorViewCompilerProvider.cs#L53-L60

[javiercn]

https://github.com/aspnet/Identity/commit/95bc2518486554be18191211e70a2ac8e8765ed3