Upgrade projects to netcoreapp3.0

aspnet / Identity

[Archived] ASP.NET Core Identity is the membership system for building ASP.NET Core web applications, including membership, login, and user data. Project moved to https://github.com/aspnet/AspNetCore

Apache License 2.0

1.96k stars 868 forks source link

Upgrade projects to netcoreapp3.0 #2072

Closed natemcmaster closed 5 years ago

natemcmaster commented 5 years ago

Changes:

Upgrade dependencies
Change TFM on Microsoft.AspNetCore.Identity to netcoreapp3.0
Remove .NET Framework tests

Part of https://github.com/aspnet/AspNetCore/issues/3754

natemcmaster commented 5 years ago

Whoa, lots of test failures. Are these already known issues @HaoK?

HaoK commented 5 years ago

That looks to be errors from the razor UI stuff, maybe the upgrade to 3.0 broke something there? @javiercn @pranavkm any ideas?

pranavkm commented 5 years ago

Can't find'C:\projects\identity\test\Identity.FunctionalTests\bin\Release\netcoreapp3.0\Identity.DefaultUI.WebSite.deps.json'

Does the 3.0 Sdk no longer generate a deps file?

natemcmaster commented 5 years ago

Does the 3.0 Sdk no longer generate a deps file?

This sounds like something @ryanbrandenburg was investigating. Is this the issue you were seeing, Ryan?

ryanbrandenburg commented 5 years ago

I don't recall having missing deps.json files.

natemcmaster commented 5 years ago

This might have been it: https://github.com/aspnet/Identity/pull/2072/commits/43bae5e91f15bffa63eadef179d7292ff7384a64 Tests pass locally now.

natemcmaster commented 5 years ago

Yup, that was me. Mea culpa, missed one line.