search

aspnet / JitBench

Repo for testing JIT stuff
Other
15 stars 24 forks source link

Jitbench fixes #83

Closed noahfalk closed 6 years ago

noahfalk commented 6 years ago

The latest version of these RunBenchmark changes updated for some merge issues and added support for doing Precompiled views. Hopefully the README is self-explanatory on how this works but happy to make updates as needed.

I haven't made any corresponding changes for Linux/Mac, but since I think most of the current benchmarking is happening on windows I want to get that unblocked. I see no reason we couldn't make a similar script for Linux/Mac as soon as we are ready expand the benchmarking effort to those platforms.

noahfalk commented 6 years ago

@rynowak - Any idea why appveyor says this is not mergeable? github doesn't seem to be having any trouble with it.

@AndyAyersMS @kouvel @davmason @JosephTremoulet - please take a look

noahfalk commented 6 years ago

cc @lt72

kouvel commented 6 years ago

Can't see the info about the automated build but upon running the following command locally: .\AspNet-GenerateStore.ps1 -InstallDir .store -Architecture x64 -Runtime win7-x64

I'm seeing the this error:

dotnet store failed.
At D:\e\jitbench\AspNet-GenerateStore.ps1:27 char:5
+     throw "dotnet store failed."
+     ~~~~~~~~~~~~~~~~~~~~~~~~~~~~
    + CategoryInfo          : OperationStopped: (dotnet store failed.:String) [], RuntimeException
    + FullyQualifiedErrorId : dotnet store failed.

dotnet store seems to be failing: https://github.com/aspnet/JitBench/pull/83/files#diff-192305a70653d6ed75f7a47a860afc81R27

kouvel commented 6 years ago

Ignore my previous comment, was using the wrong instructions. Running .\RunBenchmark.ps1 locally is showing this error:

...
  Restore completed in 2.35 sec for D:\e\jitbench\src\MusicStore\MusicStore.csproj.

 ***** Step 5 - Publish MusicStore *******
rm -r bin\Release\netcoreapp2.0\publish
rm : Cannot find path 'D:\e\jitbench\src\MusicStore\bin\Release\netcoreapp2.0\publish' because it does not exist.
At line:1 char:1
+ rm -r bin\Release\netcoreapp2.0\publish
+ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
    + CategoryInfo          : ObjectNotFound: (D:\e\jitbench\s...eapp2.0\publish:String) [Remove-Item], ItemNotFoundException
    + FullyQualifiedErrorId : PathNotFound,Microsoft.PowerShell.Commands.RemoveItemCommand
noahfalk commented 6 years ago

@kouvel - thanks let me get that fixed.

rynowak commented 6 years ago

Any idea why appveyor says this is not mergeable? github doesn't seem to be having any trouble with it.

It might be because of this merge commit: image

I would suggest doing a manual squash and rebase on top of rel/2.0.0 and then force pushing to your branch.

Consider this also a :shipit: from me.

noahfalk commented 6 years ago

@kouvel - sadly I got sidetracked with some other issues but I got a fix in for the directory issue you saw. Hopefully it will work smoothly for you now. Assuming all is well and there is no further feedback I'll try to get everything merged up properly tomorrow.

Thanks!