aspnet / JitBench

Repo for testing JIT stuff
Other
15 stars 24 forks source link

Support latest 3.0 preview #96

Open sbomer opened 5 years ago

sbomer commented 5 years ago

I'm trying to build MusicStore with the latest dotnet preview (version info at the bottom). The Microsoft.AspNetCore.All reference isn't supported on netcoreapp3.0 and above:

/Users/sven/bin/sdk/3.0.100-preview-010184/Sdks/Microsoft.NET.Sdk/targets/Microsoft.NET.Sdk.DefaultItems.targets(133,5): error NETSDK1079: The Microsoft.AspNetCore.All package is not supported when targeting .NET Core 3.0 or higher.  A FrameworkReference to Microsoft.AspNetCore.App should be used instead, and will be implicitly included by Microsoft.NET.Sdk.Web. [/Users/sven/src/aspnet/JitBench/src/MusicStore/MusicStore.csproj]

If I remove the reference I get other compilation errors:

Areas/Admin/Controllers/StoreManagerController.cs(9,17): error CS0234: The type or namespace name 'EntityFrameworkCore' does not exist in the namespace 'Microsoft' (are you missing an assembly reference?) [/Users/sven/src/aspnet/JitBench/src/MusicStore/MusicStore.csproj]
Components/GenreMenuComponent.cs(5,17): error CS0234: The type or namespace name 'EntityFrameworkCore' does not exist in the namespace 'Microsoft' (are you missing an assembly reference?) [/Users/sven/src/aspnet/JitBench/src/MusicStore/MusicStore.csproj]
Controllers/CheckoutController.cs(8,17): error CS0234: The type or namespace name 'EntityFrameworkCore' does not exist in the namespace 'Microsoft' (are you missing an assembly reference?) [/Users/sven/src/aspnet/JitBench/src/MusicStore/MusicStore.csproj]
Controllers/HomeController.cs(6,17): error CS0234: The type or namespace name 'EntityFrameworkCore' does not exist in the namespace 'Microsoft' (are you missing an assembly reference?) [/Users/sven/src/aspnet/JitBench/src/MusicStore/MusicStore.csproj]
Controllers/ShoppingCartController.cs(5,17): error CS0234: The type or namespace name 'EntityFrameworkCore' does not exist in the namespace 'Microsoft' (are you missing an assembly reference?) [/Users/sven/src/aspnet/JitBench/src/MusicStore/MusicStore.csproj]
Controllers/StoreController.cs(5,17): error CS0234: The type or namespace name 'EntityFrameworkCore' does not exist in the namespace 'Microsoft' (are you missing an assembly reference?) [/Users/sven/src/aspnet/JitBench/src/MusicStore/MusicStore.csproj]
Models/MusicStoreContext.cs(2,37): error CS0234: The type or namespace name 'EntityFrameworkCore' does not exist in the namespace 'Microsoft.AspNetCore.Identity' (are you missing an assembly reference?) [/Users/sven/src/aspnet/JitBench/src/MusicStore/MusicStore.csproj]
Models/MusicStoreContext.cs(3,17): error CS0234: The type or namespace name 'EntityFrameworkCore' does not exist in the namespace 'Microsoft' (are you missing an assembly reference?) [/Users/sven/src/aspnet/JitBench/src/MusicStore/MusicStore.csproj]
Models/MusicStoreContext.cs(4,17): error CS0234: The type or namespace name 'EntityFrameworkCore' does not exist in the namespace 'Microsoft' (are you missing an assembly reference?) [/Users/sven/src/aspnet/JitBench/src/MusicStore/MusicStore.csproj]
Models/SampleData.cs(8,17): error CS0234: The type or namespace name 'EntityFrameworkCore' does not exist in the namespace 'Microsoft' (are you missing an assembly reference?) [/Users/sven/src/aspnet/JitBench/src/MusicStore/MusicStore.csproj]
Models/ShoppingCart.cs(6,17): error CS0234: The type or namespace name 'EntityFrameworkCore' does not exist in the namespace 'Microsoft' (are you missing an assembly reference?) [/Users/sven/src/aspnet/JitBench/src/MusicStore/MusicStore.csproj]
Startup.cs(4,37): error CS0234: The type or namespace name 'EntityFrameworkCore' does not exist in the namespace 'Microsoft.AspNetCore.Identity' (are you missing an assembly reference?) [/Users/sven/src/aspnet/JitBench/src/MusicStore/MusicStore.csproj]
Startup.cs(5,17): error CS0234: The type or namespace name 'EntityFrameworkCore' does not exist in the namespace 'Microsoft' (are you missing an assembly reference?) [/Users/sven/src/aspnet/JitBench/src/MusicStore/MusicStore.csproj]
Models/MusicStoreContext.cs(10,38): error CS0246: The type or namespace name 'IdentityDbContext<>' could not be found (are you missing a using directive or an assembly reference?) [/Users/sven/src/aspnet/JitBench/src/MusicStore/MusicStore.csproj]
Models/MusicStoreContext.cs(17,47): error CS0246: The type or namespace name 'DbContextOptionsBuilder' could not be found (are you missing a using directive or an assembly reference?) [/Users/sven/src/aspnet/JitBench/src/MusicStore/MusicStore.csproj]
Models/MusicStoreContext.cs(25,16): error CS0246: The type or namespace name 'DbSet<>' could not be found (are you missing a using directive or an assembly reference?) [/Users/sven/src/aspnet/JitBench/src/MusicStore/MusicStore.csproj]
Models/MusicStoreContext.cs(26,16): error CS0246: The type or namespace name 'DbSet<>' could not be found (are you missing a using directive or an assembly reference?) [/Users/sven/src/aspnet/JitBench/src/MusicStore/MusicStore.csproj]
Models/MusicStoreContext.cs(27,16): error CS0246: The type or namespace name 'DbSet<>' could not be found (are you missing a using directive or an assembly reference?) [/Users/sven/src/aspnet/JitBench/src/MusicStore/MusicStore.csproj]
Models/MusicStoreContext.cs(28,16): error CS0246: The type or namespace name 'DbSet<>' could not be found (are you missing a using directive or an assembly reference?) [/Users/sven/src/aspnet/JitBench/src/MusicStore/MusicStore.csproj]
Models/MusicStoreContext.cs(29,16): error CS0246: The type or namespace name 'DbSet<>' could not be found (are you missing a using directive or an assembly reference?) [/Users/sven/src/aspnet/JitBench/src/MusicStore/MusicStore.csproj]
Models/MusicStoreContext.cs(30,16): error CS0246: The type or namespace name 'DbSet<>' could not be found (are you missing a using directive or an assembly reference?) [/Users/sven/src/aspnet/JitBench/src/MusicStore/MusicStore.csproj]
Models/MusicStoreContext.cs(12,34): error CS0246: The type or namespace name 'DbContextOptions<>' could not be found (are you missing a using directive or an assembly reference?) [/Users/sven/src/aspnet/JitBench/src/MusicStore/MusicStore.csproj]

Version info:

 Version:   3.0.100-preview-010184
 Commit:    c57bde4593

Runtime Environment:
 OS Name:     Mac OS X
 OS Version:  10.14
 OS Platform: Darwin
 RID:         osx.10.14-x64
 Base Path:   /Users/sven/src/dotnet/linker_arcade/.dotnet/sdk/3.0.100-preview-010184/

Host (useful for support):
  Version: 3.0.0-preview-27324-5
  Commit:  63a01b08e5

.NET Core SDKs installed:
  2.0.0 [/Users/sven/src/dotnet/linker_arcade/.dotnet/sdk]
  2.1.403 [/Users/sven/src/dotnet/linker_arcade/.dotnet/sdk]
  3.0.100-preview-010184 [/Users/sven/src/dotnet/linker_arcade/.dotnet/sdk]

.NET Core runtimes installed:
  Microsoft.AspNetCore.All 2.1.5 [/Users/sven/src/dotnet/linker_arcade/.dotnet/shared/Microsoft.AspNetCore.All]
  Microsoft.AspNetCore.App 2.1.5 [/Users/sven/src/dotnet/linker_arcade/.dotnet/shared/Microsoft.AspNetCore.App]
  Microsoft.AspNetCore.App 3.0.0-preview-19075-0444 [/Users/sven/src/dotnet/linker_arcade/.dotnet/shared/Microsoft.AspNetCore.App]
  Microsoft.NETCore.App 2.0.0 [/Users/sven/src/dotnet/linker_arcade/.dotnet/shared/Microsoft.NETCore.App]
  Microsoft.NETCore.App 2.1.5 [/Users/sven/src/dotnet/linker_arcade/.dotnet/shared/Microsoft.NETCore.App]
  Microsoft.NETCore.App 3.0.0-preview-27324-5 [/Users/sven/src/dotnet/linker_arcade/.dotnet/shared/Microsoft.NETCore.App]

To install additional .NET Core runtimes or SDKs:
  https://aka.ms/dotnet-download
sbomer commented 5 years ago

Ci has been failing with the same issue: https://travis-ci.org/aspnet/JitBench/jobs/502851655.

rynowak commented 5 years ago

@pranavkm - I think you fixed this once already, do you mind sending a PR?

sbomer commented 5 years ago

@pranavkm is this on your radar? If not, is there someone else I can ask?

pranavkm commented 5 years ago

Sorry, completed missed this. I can send a PR