aspnet / JsonPatch

[Archived] JSON PATCH library. Project moved to https://github.com/aspnet/AspNetCore
Apache License 2.0
103 stars 48 forks source link

Reorganize tests #117

Closed jbagga closed 7 years ago

jbagga commented 7 years ago

Part I for #105

This is the first PR in process of removing redundancy and adding structure to the tests

jbagga commented 7 years ago

cc @Eilon

rynowak commented 7 years ago

I think that what you've done is create a pretty reasonable organization based on what's there.

There are still a lot of non-meaningful tests - these are the ones like "replace an item in a list in a dynamic object in a dictionary" and the 345 other variations. It might be good to go through each class separately and just see what tests in that class are:

To me, most of the features in JsonPatch are not related. Lists and dynamic are not connected. So the right scale is O(n) tests for list and O(m) tests for dynamic other than O(m*n) tests for both combined.

jbagga commented 7 years ago

@rynowak @Eilon Updated

jbagga commented 7 years ago

@rynowak Updated