Allow adapters to be inherited and extended

aspnet / JsonPatch

[Archived] JSON PATCH library. Project moved to https://github.com/aspnet/AspNetCore

Apache License 2.0

103 stars 48 forks source link

Allow adapters to be inherited and extended #135

Closed jmudavid closed 6 years ago

jmudavid commented 6 years ago

Added AdapterFactory and IAdapterFactory interface
Updated all built in Adapters to contain virtual methods and protected members so they can be extended
Updated ObjectAdapter to accept an AdapterFactory as part of the constructor. If not provided, the default AdapterFactory is used
Updated the ApplyTo methods in the JsonPatchDocument to use the default AdapterFactory when an ObjectAdapter is not provided
Added an ApplyTo method which allows a custom AdapterFactory and supports the logErrorAction method

jmudavid commented 6 years ago

@rynowak Changes made... fingers crossed... Thanks again for your help on all of this.

As a side question, assuming this gets merged, are there preview NuGets available that we can use until 2.2 is released, or do we need to continue using our forks? Thanks!

rynowak commented 6 years ago

Looks awesome!

Our CI builds are available on https://dotnet.myget.org/gallery/dotnet-core

HappyNomad commented 6 years ago

Looks good enough. I don't understand why you modified JsonPatchDocument to call the new ObjectAdapter constructor when its old constructor has the same effect. But whatever - it's done!

jmudavid commented 6 years ago

@rynowak. It looks like https://dotnet.myget.org/gallery/dotnet-core is still focusing on 2.1 and not 2.2, is that right? The latest version is 2.1.0-rtm-30765 and doesn't appear to have these changes. Do I just need to wait until 2.1 is finalized, or is there another place I need to look for the build.

Thanks!

rynowak commented 6 years ago

I'll check on this.

rynowak commented 6 years ago

We have definitely had builds pass since then... 🤔

I think I gave you the wrong feed. Try this one... https://dotnet.myget.org/gallery/aspnetcore-dev

jmudavid commented 6 years ago

That worked. On the off chance anybody else stumbles across this I also had to use https://dotnet.myget.org/gallery/dotnet-core to get a preview of Microsoft.CSharp 4.6.