Closed jmudavid closed 6 years ago
@rynowak Changes made... fingers crossed... Thanks again for your help on all of this.
As a side question, assuming this gets merged, are there preview NuGets available that we can use until 2.2 is released, or do we need to continue using our forks? Thanks!
Looks awesome!
Our CI builds are available on https://dotnet.myget.org/gallery/dotnet-core
Looks good enough. I don't understand why you modified JsonPatchDocument
to call the new ObjectAdapter
constructor when its old constructor has the same effect. But whatever - it's done!
@rynowak. It looks like https://dotnet.myget.org/gallery/dotnet-core is still focusing on 2.1 and not 2.2, is that right? The latest version is 2.1.0-rtm-30765 and doesn't appear to have these changes. Do I just need to wait until 2.1 is finalized, or is there another place I need to look for the build.
Thanks!
I'll check on this.
We have definitely had builds pass since then... 🤔
I think I gave you the wrong feed. Try this one... https://dotnet.myget.org/gallery/aspnetcore-dev
That worked. On the off chance anybody else stumbles across this I also had to use https://dotnet.myget.org/gallery/dotnet-core to get a preview of Microsoft.CSharp 4.6.