search

aspnet / KestrelHttpServer

[Archived] A cross platform web server for ASP.NET Core. Project moved to https://github.com/aspnet/AspNetCore
Apache License 2.0
2.63k stars 528 forks source link

Skip falky tests caused by https://github.com/dotnet/corefx/issues/30691 #3016

Closed JunTaoLuo closed 5 years ago

JunTaoLuo commented 5 years ago

Addresses most of the tests flagged by https://github.com/aspnet/KestrelHttpServer/issues/2777 and https://github.com/aspnet/KestrelHttpServer/issues/2701. We'll start retrying these tests until the corefx issue is fixed.

Side note: Originally I was planning on adding a feature to the RetryTest attribute to limit this to Win10 since that's the only version of windows these tests are failing on but I ran into implementation issues in https://github.com/aspnet/Logging/tree/johluo/match-os-version where my Win10 machine was being recognized as Win8.

halter73 commented 5 years ago

Any plans to backport this to 2.1? With so many more functional tests, there are a lot more that need retrying there.

JunTaoLuo commented 5 years ago

We'll see about backporting to 2.1 since it will require the retry attribute in logging as well.

JunTaoLuo commented 5 years ago

Ugh... I didn't squash.