search

aspnet / KestrelHttpServer

[Archived] A cross platform web server for ASP.NET Core. Project moved to https://github.com/aspnet/AspNetCore
Apache License 2.0
2.63k stars 528 forks source link

Use Chrome instead of Chromium on Ubuntu #3055

Closed JunTaoLuo closed 5 years ago

JunTaoLuo commented 5 years ago

I'm seeing failures on the VSTS test runs. https://dnceng.visualstudio.com/public/_build/results?buildId=35319&view=logs I think it's because there's no Chromium installed. I'll need to check the agents for whether Chrome is installed instead. We should be using Chromium instead of Chrome on linux.

cc @anurse

BrennanConroy commented 5 years ago

We use chrome headless

Checking for ChromeHeadlessNoSandbox at /usr/bin/google-chrome...
2018-10-25T17:46:05.1832199Z   Located ChromeHeadlessNoSandbox at /usr/bin/google-chrome.
2018-10-25T17:46:05.1836971Z   Checking for ChromiumHeadless at undefined...
2018-10-25T17:46:05.1837332Z   Unable to locate ChromiumHeadless. Skipping.
2018-10-25T17:46:05.1841769Z   Checking for FirefoxHeadless at firefox...
2018-10-25T17:46:05.1847490Z   Located FirefoxHeadless at firefox.
2018-10-25T17:46:05.9776421Z   25 10 2018 17:46:05.976:INFO [karma]: Writing browser console to file: /home/vsts/work/1/s/artifacts/logs/browserlogs.console.2018-10-25T17-46-05-710Z
2018-10-25T17:46:06.0458241Z   25 10 2018 17:46:06.045:INFO [karma]: Karma v3.0.0 server started at http://0.0.0.0:9876/
2018-10-25T17:46:06.0461222Z   25 10 2018 17:46:06.045:INFO [launcher]: Launching browsers ChromeHeadlessNoSandbox, FirefoxHeadless with unlimited concurrency
2018-10-25T17:46:06.0502751Z   25 10 2018 17:46:06.049:INFO [launcher]: Starting browser ChromeHeadless
2018-10-25T17:46:06.0758674Z   25 10 2018 17:46:06.075:INFO [launcher]: Starting browser FirefoxHeadless
JunTaoLuo commented 5 years ago

@anurse mentioned that we should be using chromium instead on ubuntu.

JunTaoLuo commented 5 years ago

Spoke to @anurse and it turns out we don't have a good reason to have opted to install chromium on ubuntu instead of chrome. I'll just install chrome on our agents and switch the tests to use chrome instead of chromium

JunTaoLuo commented 5 years ago

I've updated all of our ubuntu agents to have chrome installed.