Use chrome instead of chromium on Ubuntu

aspnet / KestrelHttpServer

[Archived] A cross platform web server for ASP.NET Core. Project moved to https://github.com/aspnet/AspNetCore

Apache License 2.0

2.63k stars 528 forks source link

Use chrome instead of chromium on Ubuntu #3056

Closed JunTaoLuo closed 5 years ago

JunTaoLuo commented 5 years ago

Addresses #3055

JunTaoLuo commented 5 years ago

It's the only browser interop tests we have for HTTP/2 so we definitely want these to fail if chrome is not installed. Note that the tests are marked with a special attribute to fail on CI runs only. If the tests are run in a dev environment and chrome is not installed, we silently skip the tests.

JunTaoLuo commented 5 years ago

Tested on the ubuntu aspnetci agents which should be the last place that doesn't have chrome installed and the tests ran successfully so I'm going to merge this.

ryanbrandenburg commented 5 years ago

Ah, I misread the conditional. Good show then, carry on.