WIP Revert https://github.com/aspnet/KestrelHttpServer/pull/2502

aspnet / KestrelHttpServer

[Archived] A cross platform web server for ASP.NET Core. Project moved to https://github.com/aspnet/AspNetCore

Apache License 2.0

2.63k stars 528 forks source link

WIP Revert https://github.com/aspnet/KestrelHttpServer/pull/2502 #3089

Closed JunTaoLuo closed 5 years ago

JunTaoLuo commented 5 years ago

The performance regression may be too significant. See https://github.com/aspnet/Benchmarks/issues/569. cc @muratg @Eilon: @davidfowl wanted to potentially revert this for 2.2.

Eilon commented 5 years ago

The benchmark issue is comparing 2.2 preview1 and 2.2 preview2. What's up with that? @sebastienros

JunTaoLuo commented 5 years ago

The changes we made went into preview2. So the benchmarks are essentially testing without and with the 0-byte read changes.

sebastienros commented 5 years ago

I don't know, maybe related to https://github.com/aspnet/Benchmarks/issues/569

JunTaoLuo commented 5 years ago

FYI, this is still not committed to being reverted, but I figured I'll prepare the PR first in case we decide to take it. Looking into test failures now.

JunTaoLuo commented 5 years ago

Preliminary numbers suggest we'd want to take https://github.com/aspnet/KestrelHttpServer/pull/3094 instead.