search

aspnet / KestrelHttpServer

[Archived] A cross platform web server for ASP.NET Core. Project moved to https://github.com/aspnet/AspNetCore
Apache License 2.0
2.63k stars 528 forks source link

Stop skipping libuv functional tests #3091

Closed halter73 closed 5 years ago

halter73 commented 5 years ago

I accidentally removed all the test classes shared between Sockets and libuv from the libuv functional test project as part of #3036. Fortunately, we haven't made any transport changes since #3036 was merged.

halter73 commented 5 years ago

@JunTaoLuo I wonder if we should make the Http2 chrome/selenium test Socket transport only like the h2spec tests.

davidfowl commented 5 years ago

Um, do we have anything to catch this

JunTaoLuo commented 5 years ago

@halter73 Yes. @davidfowl I think the only way to detect it would be if we add a notification system that keeps track of how many tests we run and alerts us when that number drops. Can we make RaaS do that?

Drawaes commented 5 years ago

It's pretty standard ci setups to have a build gate of test number drops by more than x percent and signoff for going lower of course test number watermark is from last successful build and test run.... My 2c