search

aspnet / KestrelHttpServer

[Archived] A cross platform web server for ASP.NET Core. Project moved to https://github.com/aspnet/AspNetCore
Apache License 2.0
2.63k stars 528 forks source link

[WIP][2.2] Remove lock contention in IOQueue #3096

Closed benaadams closed 5 years ago

benaadams commented 5 years ago

For testing https://github.com/aspnet/KestrelHttpServer/pull/3093

@sebastienros version for benchmarking; should effect pipelined, may effect non-pipelined

davidfowl commented 5 years ago

This should be against 3.0 (master)

benaadams commented 5 years ago

This should be against 3.0 (master)

Yeah, that's this one https://github.com/aspnet/KestrelHttpServer/pull/3093

This is only to benchmark more easily on 2.2; which is why I've flagged it as [WIP]

sebastienros commented 5 years ago

I am not seeing any improvements on either pipelined or non-pipelined, windows or linux. Should it be an obvious win and my tests are wrong?

benaadams commented 5 years ago

K, thanks for trying. I was seeing the contention against .NET Core 3.0 (built from current source); so it may be since that is faster, contention comes more into play. Will keep the other PR open.