Adding support for --shared-runtime to dotnet-install.sh

aspnet / KoreBuild

OBSOLETE REPO - see readme

Other

37 stars 23 forks source link

Adding support for --shared-runtime to dotnet-install.sh #128

Closed pranavkm closed 7 years ago

pranavkm commented 7 years ago

The 1.0.0-preview2.1 bash script doesn't support --shared-runtime required to install Microsoft.NETCore.App 1.0.0. Back porting from the 1.0.0 dotnet-install script which is incompatible with the older runtime's download structure.

pranavkm commented 7 years ago

cc @NTaylorMullen \ @BrennanConroy

BrennanConroy commented 7 years ago

So next time we update this file how are we going to avoid back porting --shared-runtime again?

pranavkm commented 7 years ago

They have this fixed in the 1.0.0 CLI scripts. But that expects a different structure than the one they used for the preview2.1 scripts. So hopefully we wouldn't need to backport things in the future.

NTaylorMullen commented 7 years ago

:shipit:

pranavkm commented 7 years ago

@BrennanConroy ping

BrennanConroy commented 7 years ago

:shipit: