search

aspnet / KoreBuild

OBSOLETE REPO - see readme
Other
37 stars 23 forks source link

Fix globalization issue with generating build numbers #154

Closed natemcmaster closed 7 years ago

natemcmaster commented 7 years ago

Fixed part of https://github.com/aspnet/KoreBuild/issues/152#issuecomment-269346831

natemcmaster commented 7 years ago

@Yves57 I tested this in French and it should solve the comma vs period issue you found in the timestamp formats

Yves57 commented 7 years ago

Test on my computer: 1) Downloaded today the latest Razor repository sources as ZIP 2) Uncompressed 3) Called build initialize --> script error 4) Replaced the incorrect lines by your fix in common.props 5) Called build initialize again --> success!

Thank you :-)

Please note that I had not the timeout problem (second problem) because the SDK was already installed.