Use makefile.proj if available

[natemcmaster]

makefile.proj will break all shorthand dotnet commands since it matches the *.*proj pattern. This would require you to explicitly call dotnet build Repo.sln now and dotnet restore Repo.sln.

As an alternative, consider adding a msbuild project into KoreBuild that conditionally imports makefile.targets from the repo folder if it exists. This has the added benefit of allowing us to start moving the Sake lifecycle into an MSBuild project.

Concept: in KoreBuild

<Project>
    <Target Name="Build" />
    <Import Project="$(RepoDir)\makefile.targets" Condition="Exists('$(RepoDir)\makefile.targets')" />
</Project>

in repo

<Project>
   <Target Name="AfterBuild" AfterTargets="Build" />
</Project>

[pranavkm]

build/makefile.proj if the file in the root affects builds? Presumably that solves and moves more build related files to the build dir.

[natemcmaster]

I like the idea of putting it in the build/ folder. How about build/repo.targets ?

[pranavkm]

🆙 📅 with corresponding changes to https://github.com/aspnet/CoreCLR/pull/149/

[pranavkm]

🆙 📅

[natemcmaster]

:bell: can we get this in soon? I want to rebase #159 off of this work.

[pranavkm]

Merged. Let's see how this goes.

[pranavkm]

Ok - need to tweak this so that it allows calling targets that aren't declared in KoreBuild (for instance Universe has different targets). I'll play around with this and resend.

[pranavkm]

I'll send an update to this later.