aspnet / KoreBuild

OBSOLETE REPO - see readme
Other
37 stars 23 forks source link

Remove TFM parsing from xunit test target #160

Closed natemcmaster closed 7 years ago

natemcmaster commented 7 years ago

Requires update to projects that use .NET Framework in test projects. These should be updated to only include .NET Framework when building/testing on Windows.

natemcmaster commented 7 years ago

I made the changes affected repos to ensure net451 tests are only compiled on Windows. Will push once this is merged

natemcmaster commented 7 years ago

:x: blocked. Conditional TargetFrameworks properties cause VS to explode

image

natemcmaster commented 7 years ago

When this https://github.com/dotnet/roslyn-project-system/pull/1444 makes it into a build, we can return to conditioning TargetFrameworks on OS.

natemcmaster commented 7 years ago

🔔 Updated and rebased. Ready for review.