Do not assume content of the SAMPLES_PROJECT_GLOB variable - Githubissues

aspnet / KoreBuild

OBSOLETE REPO - see readme

Other

37 stars 23 forks source link

Do not assume content of the SAMPLES_PROJECT_GLOB variable #164

Closed dougbu closed 7 years ago

dougbu commented 7 years ago

samples folder may exist only to enable use of a modified SAMPLES_PROJECT_GLOB

Other alternatives to the Directory.Exists("samples") approach:

change default glob to something like sam*ples/*/*.csproj
- that wouldn't require the samples folder but may in the future match something unintended
update PathResolver.shade in Sake to avoid Directory.GetFiles(path, ...) when path doesn't exist
- could copy PathResolver.shade into KoreBuild to avoid updating Sake
- but, this option can still hide real errors very easily

dougbu commented 7 years ago

@natemcmaster and @pranavkm this fix is useful for aspnet/Performance#206. My builds currently leave many projects (those only built because they're referenced from a test) in a half-baked state.