search

aspnet / KoreBuild

OBSOLETE REPO - see readme
Other
37 stars 23 forks source link

Upgrade CLI version to 1.0.0-rc4-004828 #169

Closed natemcmaster closed 7 years ago

natemcmaster commented 7 years ago

This one is going to require manual changes to most of our repos.

For example, NetCoreAppImplicitPackageVersion is deprecated. We used this in every common.props.

pranavkm commented 7 years ago

NetCoreAppImplicitPackageVersion is not deprecated.

Did you mean "now" deprecated?

pranavkm commented 7 years ago

I suppose we can remove https://github.com/aspnet/BuildTools/blob/dev/src/Internal.AspNetCore.Sdk/build/Workarounds.targets#L29 from our workarounds if we switch to using RuntimeFrameworkVersion

natemcmaster commented 7 years ago

Yes, I mean "now" not not. I'm testing the removal of the workarounds file.