aspnet / KoreBuild

OBSOLETE REPO - see readme
Other
37 stars 23 forks source link

Merge private copy of dotnet-install scripts into CLI #247

Closed mikeharder closed 7 years ago

mikeharder commented 7 years ago

The dotnet-install scripts in the KoreBuild repo started as a copy of the scripts in the CLI repo (https://github.com/dotnet/cli/tree/master/scripts/obtain), but have since diverged. We should merge any improvements in the KoreBuild scripts back into the CLI scripts, then either:

I would lean towards downloading the scripts from the CLI repo by default, with the option to use a private copy if and when needed (e.g. to workaround a bug or breaking change).

mikeharder commented 7 years ago

It would be good if we can complete this in the next few days. The CLI is planning some renames and updates to their install scripts, and we will need to merge those changes to ingest new CLI builds.

mikeharder commented 7 years ago

We decided to keep our own copy of the scripts in the KoreBuild repo, but only update them when the copy in the CLI repo changes.

kichalla commented 7 years ago

e35d65aca7b22985ac3f38f0db3ba0be23b199e7