search

aspnet / KoreBuild

OBSOLETE REPO - see readme
Other
37 stars 23 forks source link

Restore reference assemblies in xplat #94

Closed pranavkm closed 8 years ago

pranavkm commented 8 years ago

cc @victorhurdugaci \ @pakrym \ @anurse

pranavkm commented 8 years ago

This is required for https://github.com/aspnet/Logging/pull/448

pakrym commented 8 years ago

Can we call the package NETFrameworkReferenceAssemblies to be a bit more specific? Otherwise :shipit:

natemcmaster commented 8 years ago

Just curious. Have we looked into using the official targeting pack nupkgs?

https://dotnet.myget.org/feed/dotnet-core/package/nuget/Microsoft.TargetingPack.NETFramework.v4.5.1

pranavkm commented 8 years ago

Oh nifty - didn't realize they had a package we could target. I'll give that one a try

natemcmaster commented 8 years ago

Actually, I just tried it on Microsoft.Data.Sqlite. It doesn't seem to work :-/

pranavkm commented 8 years ago

@natemcmaster could you file a CoreFx bug for it so that we can eventually move to their package.

natemcmaster commented 8 years ago

https://github.com/dotnet/corefx/issues/9735

pakrym commented 8 years ago

There is no CLI support for this. We still can use this package same way we used our own.

pranavkm commented 8 years ago

Yeah, looks like it. In our case, we don't reference the package but treat it as the search space for reference assemblies. Maybe doing something similar works just fine?

pranavkm commented 8 years ago

Their structure is kinda crummy - /Microsoft.TargetingPack.NETFramework.v4.5.1/1.0.1/lib/net451 has binaries in it whereas DOTNET_REFERENCE_ASSEMBLIES_PATH maps to C:\Program Files (x86)\Reference Assemblies\Microsoft\Framework. We'd have to move net451 -> .NETFramework/v.4.5.1 something our package already preserves. @natemcmaster do you feel strongly about switching to this package? If not we can live with what we have which seems to be working fine so far.

natemcmaster commented 8 years ago

No, it looks the like the packages aren't really ready for use anywhere than in corefx's build system. They're kinda working on making it possible, but it's not ready yet.